Skip to content
GitLab
Menu
Projects
Groups
Snippets
Help
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
Menu
Open sidebar
Plural
platform
external-dns
Commits
f14d7923
Commit
f14d7923
authored
5 years ago
by
saidst
Browse files
Options
Download
Email Patches
Plain Diff
resolved review findings as of nov 12.
parent
a5a3aa7d
master
add-infoblox-maintainers
changelog-for-v0.7.3
linki-patch-4
linki-patch-6
njuettner-patch-1
njuettner/go_modules/github.com/akamai/AkamaiOPEN-edgegrid-golang-0.9.11
njuettner/go_modules/github.com/alecthomas/kingpin-2.2.6incompatible
njuettner/go_modules/github.com/digitalocean/godo-1.34.0
njuettner/go_modules/github.com/pkg/errors-0.9.1
njuettner/go_modules/github.com/prometheus/client_golang-1.5.1
plural-provider
raffo/add-kustomize-base
raffo/arm32v7
raffo/bump-cloudbuild-timeout
raffo/bump-kustomize
raffo/bump-kustomize-version-0.7.5
raffo/drop-the-changelog
raffo/e2e-aws
raffo/edit-infoblox-maintainers
raffo/fix-1820
raffo/fix-1936
raffo/fix-ns-deletion
raffo/fix-that-typo
raffo/goarm
raffo/gpr-docker-image
raffo/kustomize-endpoints
raffo/multiarch
raffo/multiarch-docs
raffo/new-ingress-resource
raffo/new-maintainers
raffo/provider-structure-refactor
raffo/release-conventions
raffo/release-script
raffo/release-v0.7.2
raffo/remove-incubator-readme
raffo/remove-masters
raffo/split-sources
raffo/use-actions
raffo/v0.7.6
sagor999/infoblox-multiple-A-records
setup-semaphore
test-things
travis-test
v0.7.6
v0.7.5
v0.7.4
v0.7.3
v0.7.2
v0.7.1
v0.7.0
v0.6.0
v0.5.18
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
docs/tutorials/azure-private-dns.md
+0
-3
docs/tutorials/azure-private-dns.md
provider/azure_private_dns.go
+9
-9
provider/azure_private_dns.go
with
9 additions
and
12 deletions
+9
-12
docs/tutorials/azure-private-dns.md
+
0
-
3
View file @
f14d7923
...
...
@@ -4,9 +4,6 @@
This tutorial describes how to setup ExternalDNS for managing records in Azure Private DNS.
It assumes to deploy ExternalDNS as a container Kubernetes.
>Note: With Azure Private DNS we refer to the successor of the private-zone functionality in Azure DNS, which is
a separate, independent product.
It comprises of the following steps:
1) Provision Azure Private DNS
...
...
This diff is collapsed.
Click to expand it.
provider/azure_private_dns.go
+
9
-
9
View file @
f14d7923
...
...
@@ -164,7 +164,7 @@ func (p *AzurePrivateDNSProvider) ApplyChanges(ctx context.Context, changes *pla
}
func
(
p
*
AzurePrivateDNSProvider
)
zones
(
ctx
context
.
Context
)
([]
privatedns
.
PrivateZone
,
error
)
{
log
.
Debugf
(
"Retrieving Azure DNS zones for Resource Group '%s'"
,
p
.
resourceGroup
)
log
.
Debugf
(
"Retrieving Azure
Private
DNS zones for Resource Group '%s'"
,
p
.
resourceGroup
)
var
zones
[]
privatedns
.
PrivateZone
...
...
@@ -197,7 +197,7 @@ func (p *AzurePrivateDNSProvider) zones(ctx context.Context) ([]privatedns.Priva
}
}
log
.
Debugf
(
"Found %d Azure DNS zone(s)."
,
len
(
zones
))
log
.
Debugf
(
"Found %d Azure
Private
DNS zone(s)."
,
len
(
zones
))
return
zones
,
nil
}
...
...
@@ -238,7 +238,7 @@ func (p *AzurePrivateDNSProvider) mapChanges(zones []privatedns.PrivateZone, cha
if
zone
==
""
{
if
_
,
ok
:=
ignored
[
change
.
DNSName
];
!
ok
{
ignored
[
change
.
DNSName
]
=
true
log
.
Infof
(
"Ignoring changes to '%s' because a suitable Azure DNS zone was not found."
,
change
.
DNSName
)
log
.
Infof
(
"Ignoring changes to '%s' because a suitable Azure
Private
DNS zone was not found."
,
change
.
DNSName
)
}
return
}
...
...
@@ -271,12 +271,12 @@ func (p *AzurePrivateDNSProvider) deleteRecords(ctx context.Context, deleted azu
for
_
,
endpoint
:=
range
endpoints
{
name
:=
p
.
recordSetNameForZone
(
zone
,
endpoint
)
if
p
.
dryRun
{
log
.
Infof
(
"Would delete %s record named '%s' for Azure DNS zone '%s'."
,
endpoint
.
RecordType
,
name
,
zone
)
log
.
Infof
(
"Would delete %s record named '%s' for Azure
Private
DNS zone '%s'."
,
endpoint
.
RecordType
,
name
,
zone
)
}
else
{
log
.
Infof
(
"Deleting %s record named '%s' for Azure DNS zone '%s'."
,
endpoint
.
RecordType
,
name
,
zone
)
log
.
Infof
(
"Deleting %s record named '%s' for Azure
Private
DNS zone '%s'."
,
endpoint
.
RecordType
,
name
,
zone
)
if
_
,
err
:=
p
.
recordSetsClient
.
Delete
(
ctx
,
p
.
resourceGroup
,
zone
,
privatedns
.
RecordType
(
endpoint
.
RecordType
),
name
,
""
);
err
!=
nil
{
log
.
Errorf
(
"Failed to delete %s record named '%s' for Azure DNS zone '%s': %v"
,
"Failed to delete %s record named '%s' for Azure
Private
DNS zone '%s': %v"
,
endpoint
.
RecordType
,
name
,
zone
,
...
...
@@ -295,7 +295,7 @@ func (p *AzurePrivateDNSProvider) updateRecords(ctx context.Context, updated azu
name
:=
p
.
recordSetNameForZone
(
zone
,
endpoint
)
if
p
.
dryRun
{
log
.
Infof
(
"Would update %s record named '%s' to '%s' for Azure DNS zone '%s'."
,
"Would update %s record named '%s' to '%s' for Azure
Private
DNS zone '%s'."
,
endpoint
.
RecordType
,
name
,
endpoint
.
Targets
,
...
...
@@ -305,7 +305,7 @@ func (p *AzurePrivateDNSProvider) updateRecords(ctx context.Context, updated azu
}
log
.
Infof
(
"Updating %s record named '%s' to '%s' for Azure DNS zone '%s'."
,
"Updating %s record named '%s' to '%s' for Azure
Private
DNS zone '%s'."
,
endpoint
.
RecordType
,
name
,
endpoint
.
Targets
,
...
...
@@ -327,7 +327,7 @@ func (p *AzurePrivateDNSProvider) updateRecords(ctx context.Context, updated azu
}
if
err
!=
nil
{
log
.
Errorf
(
"Failed to update %s record named '%s' to '%s' for DNS zone '%s': %v"
,
"Failed to update %s record named '%s' to '%s' for
Azure Private
DNS zone '%s': %v"
,
endpoint
.
RecordType
,
name
,
endpoint
.
Targets
,
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment
Menu
Projects
Groups
Snippets
Help